H1, H2, H3 fixed

aTable · Feb 14, 2017 · 62ab4db · 62ab4db
1 parent 3f7d15a
commit 62ab4db
Show file tree

Hide file tree

Showing 12 changed files with 82 additions and 12 deletions.
diff --git a/dist/src/basic/H1.js b/dist/src/basic/H1.js
diff --git a/dist/src/basic/H1.js.map b/dist/src/basic/H1.js.map
diff --git a/dist/src/basic/H2.js b/dist/src/basic/H2.js
diff --git a/dist/src/basic/H2.js.map b/dist/src/basic/H2.js.map
diff --git a/dist/src/basic/H3.js b/dist/src/basic/H3.js
diff --git a/dist/src/basic/H3.js.map b/dist/src/basic/H3.js.map
diff --git a/dist/src/theme/components/Tab.js b/dist/src/theme/components/Tab.js
diff --git a/dist/src/theme/components/Tab.js.map b/dist/src/theme/components/Tab.js.map
diff --git a/src/basic/H1.js b/src/basic/H1.js
@@ -12,9 +12,20 @@ class H1 extends Component {
   }
 }
 
+const childrenType = function (props, propName, component) {
+  let error;
+  const prop = props[propName];
+  React.Children.forEach(prop, (child) => {
+    if (typeof child !== 'string') {
+      error = new Error(`${component} should have only string`);
+    }
+  });
+  return error;
+};
+
 H1.propTypes = {
   ...Text.propTypes,
-  children: React.PropTypes.oneOfType[React.PropTypes.node, React.PropTypes.string],
+  children: childrenType,
   style: React.PropTypes.object,
 };
 

diff --git a/src/basic/H2.js b/src/basic/H2.js
@@ -11,10 +11,20 @@ class H2 extends Component {
     );
   }
 }
+const childrenType = function (props, propName, component) {
+  let error;
+  const prop = props[propName];
+  React.Children.forEach(prop, (child) => {
+    if (typeof child !== 'string') {
+      error = new Error(`${component} should have only string`);
+    }
+  });
+  return error;
+};
 
 H2.propTypes = {
   ...Text.propTypes,
-  children: React.PropTypes.oneOfType[React.PropTypes.node, React.PropTypes.string],
+  children: childrenType,
   style: React.PropTypes.object,
 };
 

diff --git a/src/basic/H3.js b/src/basic/H3.js
@@ -12,9 +12,20 @@ class H3 extends Component {
   }
 }
 
+const childrenType = function (props, propName, component) {
+  let error;
+  const prop = props[propName];
+  React.Children.forEach(prop, (child) => {
+    if (typeof child !== 'string') {
+      error = new Error(`${component} should have only string`);
+    }
+  });
+  return error;
+};
+
 H3.propTypes = {
   ...Text.propTypes,
-  children: React.PropTypes.oneOfType[React.PropTypes.node, React.PropTypes.string],
+  children: childrenType,
   style: React.PropTypes.object,
 };
 

diff --git a/src/theme/components/Tab.js b/src/theme/components/Tab.js
@@ -7,7 +7,10 @@ export default (variables = variable) => {
   const platformStyle = variables.platformStyle;
   const platform = variables.platform;
 
-  const tabTheme = {  };
+  const tabTheme = { 
+  	flex: 1,
+  	backgroundColor: '#FFF',
+   };
 
 
   return tabTheme;