Skip to content

The case BenchmarkRange seems has some problem ? #10

Description

@yandaren
// syncmap code:
	b.Run(fmt.Sprintf("%T", &IntMap{}), func(b *testing.B) {
		m := &IntMap{}
		// setup:

		// reset:
		b.ResetTimer()

		// perG:
		perG := func(b *testing.B, pb *testing.PB, i int, m *IntMap) {
			for ; pb.Next(); i++ {
				m.Range(func(_, _ int) bool { return true })
			}
		}
		var i int64
		b.RunParallel(func(pb *testing.PB) {
			id := int(atomic.AddInt64(&i, 1) - 1)
			perG(b, pb, id*b.N, m)
		})
	})

seems the setup function is nil, then the map is empy, so at the benrchmark result, it seems vary fast

Activity

  1. a8m commented on Jun 30, 2021

    @a8m
    Owner

    Hey @yandaren, you're right. Some parts are missing there (my fault), but some parts are empty in purpose.

    Would you like to send a patch to fix this? It's basically a changed version of sync/map_bench_test.go. If don't have time, it's fine, I can address this soon. Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions