Add an error example #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8m
reviewed
Apr 3, 2021
| // a float64 and error value based on the input | ||
| func (N number) sqrt() (val float64, err error) { | ||
| if N.n < 0 { | ||
| err = errors.New("Negative value!") |
There was a problem hiding this comment.
Suggested change
| err = errors.New("Negative value!") | |
| err = errors.New("negative value") |
Error strings should not be capitalized or end with punctuation. See https://github.com/golang/go/wiki/CodeReviewComments#error-strings
|
|
||
| // define a sqrt function on "number" type that returns | ||
| // a float64 and error value based on the input | ||
| func (N number) sqrt() (val float64, err error) { |
There was a problem hiding this comment.
Please merge this example with the one above by replacing the doStuff function.
Also, this struct is not really for this example. Let's define it only as a single function.
Thanks
| func main() { | ||
| N := number{-1} | ||
| _, err := N.sqrt() | ||
| fmt.Print(err == nil) // false |
There was a problem hiding this comment.
on top of what @a8m suggested, it'd also be better to demo err.Error() as well.
Suggested change
| fmt.Print(err == nil) // false | |
| fmt.Print(err == nil) // false | |
| fmt.Print(err.Error()) // negative value |
rexagod
added a commit
to rexagod/golang-cheat-sheet
that referenced
this pull request
Apr 3, 2021
Merged examples and removed struct. Continuation of a8m#62 since I deleted that branch earlier.
rexagod
added a commit
to rexagod/golang-cheat-sheet
that referenced
this pull request
Apr 3, 2021
Merged examples and removed struct. Continuation of a8m#62 since I deleted that branch earlier.
rexagod
added a commit
to rexagod/golang-cheat-sheet
that referenced
this pull request
Apr 4, 2021
Merged examples and removed struct. Continuation of a8m#62 since I deleted that branch earlier.
rexagod
added a commit
to rexagod/golang-cheat-sheet
that referenced
this pull request
Apr 4, 2021
Merged examples and removed struct. Continuation of a8m#62 since I deleted that branch earlier.
a8m
pushed a commit
that referenced
this pull request
Apr 4, 2021
Merged examples and removed struct. Continuation of #62 since I deleted that branch earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't find the current "error" section to be convincing in it's expression and semantics, hence I added this so anyone can quickly get a clear idea about it.
PS. Thank you for this cheat sheet!