Skip to content

Commit

Permalink
fetch & fetchpost: reduce default max-errors from 100 to 10
Browse files Browse the repository at this point in the history
coupled with the default retry of 5 and default timeout of 15 secs, 10 is more than enough to know that the request connection is flaky
[skip ci]
  • Loading branch information
jqnatividad committed Oct 19, 2022
1 parent fd35a89 commit e06bc0b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/cmd/fetch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Fetch options:
CAUTION: Only use zero for APIs that use RateLimit and/or Retry-After headers,
otherwise your fetch job may look like a Denial Of Service attack.
Even though zero is the default, this is mitigated by --max-errors having a
default of 100.
default of 10.
[default: 0 ]
--timeout <seconds> Timeout for each URL request.
[default: 15 ]
Expand All @@ -130,7 +130,7 @@ Fetch options:
[default: 5]
--max-errors <count> Maximum number of errors before aborting.
Set to zero (0) to continue despite errors.
[default: 100 ]
[default: 10 ]
--store-error On error, store error code/message instead of blank value.
--cache-error Cache error responses even if a request fails. If an identical URL is requested,
the cached error is returned. Otherwise, the fetch is attempted again
Expand Down
4 changes: 2 additions & 2 deletions src/cmd/fetchpost.rs
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ Fetch options:
CAUTION: Only use zero for APIs that use RateLimit and/or Retry-After headers,
otherwise your fetchpost job may look like a Denial Of Service attack.
Even though zero is the default, this is mitigated by --max-errors having a
default of 100.
default of 10.
[default: 0 ]
--timeout <seconds> Timeout for each URL request.
[default: 15 ]
Expand All @@ -111,7 +111,7 @@ Fetch options:
[default: 5]
--max-errors <count> Maximum number of errors before aborting.
Set to zero (0) to continue despite errors.
[default: 100 ]
[default: 10 ]
--store-error On error, store error code/message instead of blank value.
--cache-error Cache error responses even if a request fails. If an identical URL is requested,
the cached error is returned. Otherwise, the fetch is attempted again
Expand Down

0 comments on commit e06bc0b

Please sign in to comment.