Update a2ui-core blueprint#1991
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the A2UI Core blueprint to document the Node Graph Layer, multi-version protocol branching, the validation layer (A2uiValidator), and a structured exception hierarchy. The review feedback correctly identifies that the v0_9_1 directory is missing from the documented file structures for both schema/ and basic_catalog/ despite being listed as a supported version. Additionally, it is recommended to add the targetVersion property to the ValidationConfig interface to match the SDK's capabilities.
| - **`NodeGraph`**: Binds directly to a `SurfaceModel` to construct and manage the root node hierarchy (`rootNode`), handling dynamic updates, node instantiation, and cleanup lifecycle callbacks. | ||
|
|
||
| ```typescript | ||
| class ComponentNode { |
There was a problem hiding this comment.
Want to leave this out for now so that @andrewkolos can add it later? Or else if this is exactly the same as Andrew's design, let's just submit.
Up to what you prefer, @andrewkolos !!
There was a problem hiding this comment.
Hmm, yeah I do think the ComponentNode bits are likely to change. The bits can stay in the PR to allow for me to comment on some things. Alternatively, we can leave these bits out for now, and the design can be updated to have details from this PR that are missing. I can't elaborate on these discrepancies right now as I need to run to the dentist, but I'll be back to comment on more things later.
There was a problem hiding this comment.
I'm back and I realized my previous comment was indecisive. I suggest pulling the node-layer parts out for now. I think the rest is fine to stay, though I think the validation layer stuff is out of date with the design.
|
FYI, there're still on going discussions around the a2ui-core APIs. I'll update the blueprint later once the API design is finalized. |
4 participants
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
One time:
For this PR:
If you need help, consider asking for advice on the discussion board.