-
Notifications
You must be signed in to change notification settings - Fork 288
refactor(spec)!: Large refactor of specification to separate application protocol definition from mapping to transports. #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @a2a-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates an updated version of the A2A specification, bringing significant enhancements and refinements to the gRPC Python client. The changes encompass the introduction of new task listing capabilities, a comprehensive renaming effort for fields and service methods to improve API clarity, and stricter data validation through the explicit marking of required fields. Additionally, the update includes minor optimizations in the generated Python protobuf code and clearer documentation for data model fields. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the generated Protobuf and gRPC files to align with a new version of the A2A specification. While the generated files themselves seem correct, this PR appears to be critically incomplete. The gRPC service methods have been renamed (e.g., TaskSubscription to SubscribeToTask, CreateTaskPushNotificationConfig to SetTaskPushNotificationConfig), but the client and server code that implements and uses these methods (like src/a2a/client/transports/grpc.py and src/a2a/server/request_handlers/grpc_handler.py) have not been updated accordingly in this pull request. This will lead to build failures and runtime errors. Please include the necessary updates to the client and server implementation files to match the new gRPC interface.
|
|
||
| class SendMessageConfiguration(_message.Message): | ||
| __slots__ = ("accepted_output_modes", "push_notification", "history_length", "blocking") | ||
| __slots__ = () |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The __slots__ attribute for this and other Protobuf message classes in this file has been changed to an empty tuple. This removes the memory and performance benefits of using __slots__ and also disables the protection against accidentally setting non-existent attributes, which can hide typos. Was this change intentional? If not, it might be worth investigating the mypy-protobuf generator settings to see if __slots__ can be re-enabled for these generated classes.
| """A2AService defines the operations of the A2A protocol. | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated docstrings for A2AServiceStub, A2AServiceServicer, and several methods are much shorter and have lost some useful details that were present in the previous version. For example, the old class docstrings explained the resource model and available operations, which was helpful context for developers. While this is a generated file, it might be worth checking if the comments in the source .proto file can be improved to restore this information in the generated code.
Commit: a2aproject/A2A@b078419
Release-As: 1.0.0