Skip to content

ci: Remove noxfile and add shell script for formatting#331

Merged
holtskinner merged 5 commits into
mainfrom
formatting
Jul 21, 2025
Merged

ci: Remove noxfile and add shell script for formatting#331
holtskinner merged 5 commits into
mainfrom
formatting

Conversation

@holtskinner

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @holtskinner, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's code formatting process by migrating from Nox to a direct shell script. This change simplifies the dependency chain for formatting, makes the process more transparent, and updates all relevant documentation and configuration to reflect the new approach.

Highlights

  • CI/CD Tooling Migration: I've removed the noxfile.py which previously managed formatting tasks, replacing it with a new scripts/format.sh shell script. This simplifies the CI/CD setup for code formatting.
  • Developer Workflow Update: The pull request template has been updated to guide developers to use the new bash scripts/format.sh command for local formatting, ensuring consistency with the new CI approach.
  • Configuration Cleanup: I've updated various configuration files (.coveragerc, .github/actions/spelling/excludes.txt, .ruff.toml) to remove references to the now-deleted noxfile.py.
  • Dependency Management: The pyproject.toml file has been updated to explicitly list formatting tools (pyupgrade, autoflake, no_implicit_optional) as development dependencies, which were previously implicitly managed by Nox.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces nox for formatting tasks with a new bash script, scripts/format.sh. The changes across various configuration files are consistent with this goal. The review focuses on improving the new shell script's robustness and maintainability.

Comment thread scripts/format.sh
Comment thread scripts/format.sh Outdated
Comment thread scripts/format.sh Outdated
holtskinner and others added 4 commits July 21, 2025 11:31
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@holtskinner holtskinner merged commit 0756d23 into main Jul 21, 2025
8 checks passed
@holtskinner holtskinner deleted the formatting branch July 21, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant