Skip to content

fix: Eliminate race condition in testInputRequiredWorkflow #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kabir merged 1 commit into from
Feb 5, 2026
Merged

fix: Eliminate race condition in testInputRequiredWorkflow #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions tests/server-common/src/test/java/io/a2a/server/apps/common/AbstractA2AServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,9 +1512,17 @@ public void testInputRequiredWorkflow() throws Exception {
AtomicBoolean initialUnexpectedEvent = new AtomicBoolean(false);

BiConsumer<ClientEvent, AgentCard> initialConsumer = (event, agentCard) -> {
// Idempotency guard: prevent late events from modifying state after latch countdown
if (initialLatch.getCount() == 0) {
return;
}
if (event instanceof TaskEvent te) {
initialState.set(te.getTask().status().state());
initialLatch.countDown();
TaskState state = te.getTask().status().state();
initialState.set(state);
// Only count down when we receive INPUT_REQUIRED, not intermediate states like WORKING
if (state == TaskState.INPUT_REQUIRED) {
initialLatch.countDown();
}
} else {
initialUnexpectedEvent.set(true);
}
Expand All @@ -1538,9 +1546,17 @@ public void testInputRequiredWorkflow() throws Exception {
AtomicBoolean completionUnexpectedEvent = new AtomicBoolean(false);

BiConsumer<ClientEvent, AgentCard> completionConsumer = (event, agentCard) -> {
// Idempotency guard: prevent late events from modifying state after latch countdown
if (completionLatch.getCount() == 0) {
return;
}
if (event instanceof TaskEvent te) {
completedState.set(te.getTask().status().state());
completionLatch.countDown();
TaskState state = te.getTask().status().state();
completedState.set(state);
// Only count down when we receive COMPLETED, not intermediate states like WORKING
if (state == TaskState.COMPLETED) {
completionLatch.countDown();
}
} else {
completionUnexpectedEvent.set(true);
}
Expand Down