Skip to content

fix: Sending an invalid message to the server raises an InternalServerError #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehsavoie merged 1 commit into from
Dec 12, 2025
+258 −97
Merged

fix: Sending an invalid message to the server raises an InternalServerError #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions http-client/src/main/java/io/a2a/client/http/A2ACardResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import io.a2a.grpc.utils.JSONRPCUtils;
import io.a2a.grpc.utils.ProtoUtils;
import io.a2a.json.JsonProcessingException;
import io.a2a.spec.A2AClientError;
import io.a2a.spec.A2AClientJSONError;
import io.a2a.spec.AgentCard;
Expand Down Expand Up @@ -105,13 +106,10 @@ public AgentCard getAgentCard() throws A2AClientError, A2AClientJSONError {

try {
io.a2a.grpc.AgentCard.Builder agentCardBuilder = io.a2a.grpc.AgentCard.newBuilder();
JSONRPCUtils.parseJsonString(body, agentCardBuilder);
JSONRPCUtils.parseJsonString(body, agentCardBuilder, null);
return ProtoUtils.FromProto.agentCard(agentCardBuilder);
} catch (JSONRPCError e) {
} catch (JSONRPCError | JsonProcessingException e) {
throw new A2AClientJSONError("Could not unmarshal agent card response", e);
}

}


}
5 changes: 3 additions & 2 deletions http-client/src/test/java/io/a2a/client/http/A2ACardResolverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import com.google.protobuf.util.JsonFormat;
import io.a2a.grpc.utils.JSONRPCUtils;
import io.a2a.grpc.utils.ProtoUtils;
import io.a2a.json.JsonProcessingException;
import io.a2a.spec.A2AClientError;
import io.a2a.spec.A2AClientJSONError;
import io.a2a.spec.AgentCard;
Expand Down Expand Up @@ -79,9 +80,9 @@ public void testGetAgentCardSuccess() throws Exception {
assertEquals(expected, requestCardString);
}

private AgentCard unmarshalFrom(String body) {
private AgentCard unmarshalFrom(String body) throws JsonProcessingException {
io.a2a.grpc.AgentCard.Builder agentCardBuilder = io.a2a.grpc.AgentCard.newBuilder();
JSONRPCUtils.parseJsonString(body, agentCardBuilder);
JSONRPCUtils.parseJsonString(body, agentCardBuilder, null);
return ProtoUtils.FromProto.agentCard(agentCardBuilder);
}

Expand Down
6 changes: 4 additions & 2 deletions reference/jsonrpc/src/main/java/io/a2a/server/apps/quarkus/A2AServerRoutes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import static jakarta.ws.rs.core.MediaType.APPLICATION_JSON;
import static jakarta.ws.rs.core.MediaType.SERVER_SENT_EVENTS;

import com.google.gson.JsonSyntaxException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -39,6 +40,7 @@
import io.a2a.spec.GetTaskPushNotificationConfigResponse;
import io.a2a.spec.GetTaskRequest;
import io.a2a.spec.GetTaskResponse;
import io.a2a.spec.IdJsonMappingException;
import io.a2a.spec.InternalError;
import io.a2a.spec.InvalidParamsJsonMappingException;
import io.a2a.spec.JSONParseError;
Expand Down Expand Up @@ -113,12 +115,12 @@ public void invokeJSONRPCHandler(@Body String body, RoutingContext rc) {
error = new JSONRPCErrorResponse(e.getId(), new io.a2a.spec.InvalidParamsError(null, e.getMessage(), null));
} catch (MethodNotFoundJsonMappingException e) {
error = new JSONRPCErrorResponse(e.getId(), new io.a2a.spec.MethodNotFoundError(null, e.getMessage(), null));
} catch (io.a2a.spec.IdJsonMappingException e) {
} catch (IdJsonMappingException e) {
error = new JSONRPCErrorResponse(e.getId(), new io.a2a.spec.InvalidRequestError(null, e.getMessage(), null));
} catch (JsonMappingException e) {
// General JsonMappingException - treat as InvalidRequest
error = new JSONRPCErrorResponse(new io.a2a.spec.InvalidRequestError(null, e.getMessage(), null));
} catch (com.google.gson.JsonSyntaxException e) {
} catch (JsonSyntaxException e) {
error = new JSONRPCErrorResponse(new JSONParseError(e.getMessage()));
} catch (JsonProcessingException e) {
error = new JSONRPCErrorResponse(new JSONParseError(e.getMessage()));
Expand Down
Loading