chore: Updating JSpecify coverage#534
Conversation
Summary of ChangesHello @ehsavoie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the null-safety of the codebase by integrating JSpecify annotations. It involves marking numerous fields, parameters, and return types as potentially nullable, applying package-level null-marking, and configuring Error Prone to enforce these nullability contracts more rigorously. These changes aim to prevent Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request primarily focuses on enhancing null-safety across the codebase by introducing JSpecify @Nullable annotations to numerous fields, method parameters, and return types in various classes such as DynamicBomVerifier, RequestContext, EventQueue, TaskManager, and TaskUpdater. New package-info.java files with @NullMarked are added to several packages to enable JSpecify nullness analysis. The pom.xml is updated to include RequireExplicitNullMarking:WARN and ExhaustiveOverride=true for Error Prone. Additionally, the changes include refactoring A2AServerRoutes.java to return an empty string instead of null for getUsername(), adding explicit null checks and error handling in DefaultRequestHandler, ResultAggregator, TaskManager, AsyncExecutorProducer, and AsyncUtils to prevent NullPointerExceptions, and making minor adjustments in the TCK AgentExecutorProducer for task creation and cancellation logic.
Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Adding more JSpecify coverage Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
Adding more JSpecify coverage