fix: Store push notification config for newly created tasks

[kabir]

This was missing in the non-streaming message sends

Follows up on #383 and #482

The TCK is not testing this, but it is introduced in a2aproject/a2a-tck#94

[gemini-code-assist]

Summary of Changes

Hello @kabir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a gap in the system's handling of push notification configurations for tasks initiated through non-streaming message sends. By introducing the necessary logic to store these configurations upon task creation, it ensures consistent behavior across different message sending mechanisms and resolves a previously identified bug, enhancing the reliability of push notification delivery.

Highlights

• Push Notification Configuration Storage: Implemented logic to correctly store push notification configurations for newly created tasks when messages are sent via non-streaming (blocking) methods.
• Behavior Alignment: Ensures that the handling of push notification configurations for non-streaming message sends now mirrors the existing, correct behavior for streaming message sends.
• Comprehensive Testing: Added new unit tests to validate that push notification configurations are properly stored for both newly created and existing tasks in blocking message send scenarios, addressing a previously identified bug.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue where push notification configurations were not stored for newly created tasks in non-streaming message sends. The change adds logic to onMessageSend to handle this case, mirroring the existing logic for streaming sends. Additionally, new tests are added to verify the fix for new tasks and to ensure no regressions for existing tasks.

My review includes a couple of suggestions. First, in DefaultRequestHandler.java, I recommend making the condition for storing the push config more specific to new tasks to avoid redundant operations. Second, in DefaultRequestHandlerTest.java, I suggest making a test assertion stricter for better correctness guarantees. Overall, the changes are good and the tests are comprehensive.