fix: Adding support for Jspecify for JSONRPC

[ehsavoie]

fixing issue #335

Fixes #335 🦕

[gemini-code-assist]

Summary of Changes

Hello @ehsavoie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the null safety and configuration of the JSONRPC transport layer by integrating JSpecify annotations. These annotations provide a standardized way to specify nullability, enhancing code clarity and reducing potential runtime errors. Additionally, the changes introduce more flexibility in configuring the HTTP client used by the transport.

Highlights

• JSpecify Annotations: This PR introduces JSpecify annotations to enhance nullability checks in the JSONRPC transport layer.
• Improved Null Safety: By adding @Nullable annotations, the code becomes more explicit about which parameters and return values can be null, reducing the risk of NullPointerExceptions.
• Configuration Flexibility: Updates to JSONRPCTransportConfig and JSONRPCTransportConfigBuilder allow for more flexible configuration of the HTTP client.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces JSpecify annotations to enhance null-safety in the JSON-RPC transport, which is a valuable improvement for code quality. The changes are generally well-executed, with @Nullable annotations added where appropriate and @NullMarked applied at the package level. I've identified a few areas where the nullability annotations could be more consistent or accurate. My review includes suggestions to address an inconsistency in parameter nullability between similar methods and to correct a couple of fields that are incorrectly marked as nullable, which will help ensure the null-safety contract is precise and clear.

[ehsavoie]

/gemini review

[gemini-code-assist]

Code Review

This pull request significantly improves the null-safety of the codebase by integrating JSpecify annotations. The changes correctly introduce @Nullable annotations to fields, method parameters, and return types, and enable NullAway checks via package-info.java files and pom.xml configurations. This is a positive step towards preventing NullPointerExceptions at compile time.

However, there are a couple of areas that warrant attention:

1. Maven old Profile Duplication: The newly added old Maven profile in pom.xml duplicates compiler configurations and uses older versions of Error Prone and NullAway. This could lead to build inconsistencies and confusion.
2. NullAway Suppression: A @SuppressWarnings("NullAway") annotation was added in JSONRPCHandler.java. While sometimes necessary, it's generally better to address the underlying nullability issue directly rather than suppressing the warning, to fully benefit from null-safety analysis.

[ehsavoie]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces JSpecify annotations for null-safety in the JSON-RPC transport module, which is a great step towards improving code robustness. The changes correctly apply @Nullable annotations to various fields, parameters, and method returns, and enable null-safety checks in the build process. However, I've found one critical issue where a parameter is annotated as nullable but is then checked for non-nullness, which will lead to a NullPointerException. This needs to be fixed to ensure the code behaves as expected with the new nullability contracts.