Skip to content

fix: Remove unnecessary http port+host#422

Closed
kabir wants to merge 1 commit intoa2aproject:mainfrom
kabir:event-queues-replicated-example
Closed

fix: Remove unnecessary http port+host#422
kabir wants to merge 1 commit intoa2aproject:mainfrom
kabir:event-queues-replicated-example

Conversation

@kabir
Copy link
Collaborator

@kabir kabir commented Oct 31, 2025

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kabir, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the configuration for the cloud deployment example server by eliminating unnecessary HTTP server settings. By removing the explicit quarkus.http.port and quarkus.http.host entries from application.properties, the application will now rely on Quarkus's default behavior or environment-provided configurations, leading to a cleaner and potentially more flexible setup.

Highlights

  • Configuration Cleanup: Removed explicit quarkus.http.port and quarkus.http.host settings from the application.properties file within the cloud deployment example server.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unnecessary HTTP port and host configuration from the Quarkus application.properties file, relying on the framework's default values. While this is functionally correct, I have raised a concern about the clarity of the example. For educational purposes, explicit configuration is often preferable to implicit defaults. I've suggested restoring the configuration to make the example easier to understand for all users, regardless of their familiarity with Quarkus.

@@ -1,10 +1,6 @@
# Agent Configuration
agent.url=${AGENT_URL:http://localhost:8080}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity in an example project, it's beneficial to explicitly state the HTTP configuration. This helps users who may not be familiar with Quarkus's default port and host settings. Relying on implicit defaults can make the example harder to understand. Consider restoring the explicit configuration for the HTTP server.


# HTTP Server
quarkus.http.port=8080
quarkus.http.host=0.0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant