Repository navigation
refactor: Add metadata parameters to TaskUpdater and MessageResponder methods - #394
Merged
darrelmiller merged 6 commits intoJun 1, 2026
Merged
Conversation
Extend all TaskUpdater and MessageResponder methods with an optional Dictionary<string, JsonElement>? metadata parameter, allowing callers to attach protocol-level metadata to tasks, status update events, artifacts, and messages. - SubmitAsync: metadata flows to AgentTask.Metadata - Status update methods (StartWorkAsync, CompleteAsync, FailAsync, CancelAsync, RejectAsync, RequireInputAsync, RequireAuthAsync): metadata flows to TaskStatusUpdateEvent.Metadata - AddArtifactAsync: metadata flows to Artifact.Metadata - ReplyAsync (both overloads): metadata flows to Message.Metadata - Update all callers using positional CancellationToken to named args - Add 11 unit tests covering metadata propagation for every method Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces optional metadata support across the agent communication framework, specifically within MessageResponder and TaskUpdater, and standardizes the use of named arguments for cancellationToken throughout the codebase. The changes are supported by new unit tests and updates to sample agents. Feedback suggests that the default implementation of CancelAsync in IAgentHandler should propagate metadata from the RequestContext to ensure protocol-level metadata is correctly attached to cancellation events.
SergeyMenshykh
changed the title
darrelmiller
approved these changes
May 26, 2026
3 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends all
TaskUpdaterandMessageRespondermethods with an optionalDictionary<string, JsonElement>? metadataparameter, allowing callers to attach protocol-level metadata to tasks, status update events, artifacts, and messages.Changes
All new parameters are optional (
= null) and placed beforeCancellationToken, preserving backward compatibility for callers using named arguments.Caller updates
Updated all existing call sites that passed
CancellationTokenpositionally to use the namedcancellationToken:syntax, across samples, tests, and theIAgentHandlerdefault implementation.Tests
Added 11 new unit tests verifying metadata flows through to the correct model objects for every method on both classes.