Repository navigation
fix: remove /card endpoint from HTTP+JSON binding - #385
Merged
darrelmiller merged 2 commits intoMay 31, 2026
Merged
Conversation
Remove the GET /card convenience endpoint from MapHttpA2A and the associated agentCard parameter. The endpoint was not part of the A2A specification, and requiring an AgentCard parameter made it impossible to use MapHttpA2A without providing a stub/fake agent card just to satisfy the parameter, even though the endpoint would never be called. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the AgentCard dependency and the /card REST endpoint from the A2A AspNetCore implementation. Key changes include removing AgentCard parameters from MapA2A and MapHttpA2A, and deleting the GetAgentCardRestAsync handler. A review comment suggests adding a null check for the path parameter in MapHttpA2A to prevent potential ArgumentNullException errors if a null value is explicitly passed.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
darrelmiller
approved these changes
May 26, 2026
3 of 11 tasks
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
GET /cardconvenience endpoint fromMapHttpA2Aand the associatedagentCardparameter. The endpoint was not part of the A2A specification, and requiring anAgentCardparameter made it impossible to useMapHttpA2Awithout providing a stub/fake agent card just to satisfy the parameter, even though the endpoint would never be called.Changes
agentCardparameter fromMapHttpA2A.GET /cardroute registration fromMapHttpA2A.GetAgentCardRestAsyncfromA2AHttpProcessor.AgentCardDI resolution from theMapA2Aoverload that used DI-registered services (the resolved card was only needed for the now-removed/cardendpoint).Agent card discovery is still available via
MapWellKnownAgentCardor the.well-known/agent-card.jsonendpoint.