-
Couldn't load subscription status.
- Fork 41
fix: Add PushNotificationConfig types to JSON serialization context #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Add PushNotificationConfig types to JSON serialization context #215
Conversation
Fixes a2aproject#203 Added missing JsonSerializable attributes for PushNotificationConfig and PushNotificationAuthenticationInfo to the source-generated JSON context. These types are used in TaskPushNotificationConfig and need to be explicitly registered for proper serialization, especially in Native AOT scenarios. This resolves the 'JsonTypeInfo metadata not provided' error when retrieving AgentCard with push notification capabilities.
Summary of ChangesHello @sam-baraka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical serialization issue by explicitly registering previously missing nested types, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a clear and correct fix for the System.NotSupportedException encountered during JSON serialization. The problem description is excellent, and the solution of adding the missing PushNotificationConfig and PushNotificationAuthenticationInfo types to the source-generated JsonContext is spot on. The change is minimal and effectively resolves the bug. I have one minor suggestion to improve long-term maintainability.
Reordered the A2A type registrations in alphabetical order for better maintainability and to make it easier to verify if a type is already registered or add new types in the correct location.
Description
Fixes #203
This PR adds the missing
PushNotificationConfigandPushNotificationAuthenticationInfotypes to the source-generated JSON serialization context inA2AJsonUtilities.Problem
When retrieving an AgentCard or serializing push notification configurations, the following error occurred:
This happened because while
TaskPushNotificationConfigwas registered in the JSON context, its nested types (PushNotificationConfigandPushNotificationAuthenticationInfo) were not explicitly registered.Solution
Added the following type registrations to
A2AJsonUtilities.JsonContext:[JsonSerializable(typeof(PushNotificationAuthenticationInfo))][JsonSerializable(typeof(PushNotificationConfig))]Testing
Changes
src/A2A/A2AJsonUtilities.cs- Added 2 type registrations to the JSON source generation context