Skip to content

Conversation

@sam-baraka
Copy link

Description

Fixes #203

This PR adds the missing PushNotificationConfig and PushNotificationAuthenticationInfo types to the source-generated JSON serialization context in A2AJsonUtilities.

Problem

When retrieving an AgentCard or serializing push notification configurations, the following error occurred:

System.NotSupportedException: JsonTypeInfo metadata for type 'A2A.PushNotificationConfig' was not provided by TypeInfoResolver

This happened because while TaskPushNotificationConfig was registered in the JSON context, its nested types (PushNotificationConfig and PushNotificationAuthenticationInfo) were not explicitly registered.

Solution

Added the following type registrations to A2AJsonUtilities.JsonContext:

  • [JsonSerializable(typeof(PushNotificationAuthenticationInfo))]
  • [JsonSerializable(typeof(PushNotificationConfig))]

Testing

  • ✅ All 642 existing tests pass
  • ✅ Specifically tested 26 push notification-related tests
  • ✅ AgentCard serialization/deserialization works correctly
  • ✅ TaskPushNotificationConfig serialization/deserialization works correctly
  • ✅ Build succeeds for all target frameworks (net8.0, net9.0, netstandard2.0)

Changes

  • Modified: src/A2A/A2AJsonUtilities.cs - Added 2 type registrations to the JSON source generation context

Fixes a2aproject#203

Added missing JsonSerializable attributes for PushNotificationConfig
and PushNotificationAuthenticationInfo to the source-generated JSON
context. These types are used in TaskPushNotificationConfig and need
to be explicitly registered for proper serialization, especially in
Native AOT scenarios.

This resolves the 'JsonTypeInfo metadata not provided' error when
retrieving AgentCard with push notification capabilities.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sam-baraka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical serialization issue by explicitly registering previously missing nested types, PushNotificationConfig and PushNotificationAuthenticationInfo, within the application's JSON serialization context. This ensures that AgentCard and TaskPushNotificationConfig objects can be correctly serialized and deserialized, preventing runtime exceptions and maintaining data integrity across the system.

Highlights

  • JSON Serialization Fix: Added PushNotificationConfig and PushNotificationAuthenticationInfo types to the A2AJsonUtilities source-generated JSON serialization context. This resolves System.NotSupportedException errors encountered when retrieving AgentCards or serializing push notification configurations, ensuring proper serialization of nested types.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a clear and correct fix for the System.NotSupportedException encountered during JSON serialization. The problem description is excellent, and the solution of adding the missing PushNotificationConfig and PushNotificationAuthenticationInfo types to the source-generated JsonContext is spot on. The change is minimal and effectively resolves the bug. I have one minor suggestion to improve long-term maintainability.

@sam-baraka sam-baraka changed the title Fix: Add PushNotificationConfig types to JSON serialization context fix: Add PushNotificationConfig types to JSON serialization context Oct 28, 2025
Reordered the A2A type registrations in alphabetical order for better
maintainability and to make it easier to verify if a type is already
registered or add new types in the correct location.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: JsonTypeInfo metadata for type 'A2A.PushNotificationConfig' was not provided by TypeInfoResolver

1 participant