fix: Add name field to FilePart protobuf message#983
Conversation
This is present in the JSON-RPC spec and was missing from the gRPC spec.
There was a problem hiding this comment.
Summary of Changes
Hello @mikeas1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a discrepancy between the gRPC and JSON-RPC specifications by adding a missing "name" field to the "FilePart" protobuf message. This ensures consistency and completeness in the data structure definitions.
Highlights
- Protocol Buffer Definition Update: Added a "name" field of type "string" with field number "4" to the FilePart message in specification/grpc/a2a.proto. This rectifies an omission where the field was present in the JSON-RPC specification but missing from the gRPC definition.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a name field to the FilePart message within the gRPC protobuf definition. This is a valuable fix that brings the gRPC specification in line with the JSON-RPC specification, which already includes this field. The change is implemented correctly and ensures consistency across different transport protocols defined in the A2A standard. I find the change to be correct and have no further suggestions.
This is present in the JSON-RPC spec and was missing from the gRPC definition.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.nox -s formatfrom the repository root to format)Fixes: #984