Arithmic/streaming #638
Open
Arithmic/streaming #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… design_oracle
moodlezoup
requested changes
Apr 10, 2025
jolt-core/src/jolt/vm/output.log
Outdated
There was a problem hiding this comment.
delete or add to .gitignore
jolt-core/src/r1cs/builder.rs
Outdated
Comment on lines
668
to
679
|
|
||
| // pub fn streaming_compute_spartan_Az_Bz_Cz( | ||
| // &self, | ||
| // flattened_polynomials: &[&[F]], // N variables of (S steps) | ||
| // ) -> SpartanInterleavedPolynomial<F> { | ||
| // SpartanInterleavedPolynomial::new( | ||
| // &self.uniform_builder.constraints, | ||
| // &self.offset_equality_constraints, | ||
| // flattened_polynomials, | ||
| // self.padded_rows_per_step(), | ||
| // ) | ||
| // } |
jolt-core/src/poly/eq_poly.rs
Outdated
Comment on lines
15
to
23
| pub struct StreamingEqPolynomial<F> { | ||
| r: Vec<F>, | ||
| num_vars: usize, | ||
| ratios: Vec<F>, | ||
| idx: usize, | ||
| prev_eval: F, | ||
| scaling_factor: Option<F>, | ||
| } | ||
|
|
There was a problem hiding this comment.
Since we consider square root space acceptable, let's use a technique similar to SplitEqPolynomial instead of this log-space variant.
|
|
||
| let mut witness_eval_for_final_eval = vec![vec![F::zero(); 2]; num_polys]; | ||
| let num_shards = (1 << num_rounds) / shard_length; | ||
| for i in 0..num_rounds { |
There was a problem hiding this comment.
nit:
Suggested change
| for i in 0..num_rounds { | |
| for round in 0..num_rounds { |
jolt-core/src/jolt/vm/mod.rs
Outdated
Comment on lines
489
to
490
|
|
||
| // pub type StreamingJoltPolynomials<F: JoltField> = JoltStuff<StreamingPolynomial<JoltTraceStep<JoltInstructionSet>, F>>; |
fix stream prove cubic
…tream/spartan_optimisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements "oracles" to stream the jolt polynomials and Az, Bz, Cz (for uniform Spartan used in Jolt). It also has an implementation of a streaming sum-check prover