Add InputDescriptor.toRequestOptions #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodh
requested changes
Aug 20, 2024
|
|
||
| representations.forEach { representation -> | ||
| "${representation.name}: RequestOptions -> InputDescriptor -> RequestOptions quasi equality" { | ||
| repeat(3) { |
There was a problem hiding this comment.
To get more permutations of requested attributes i.e. empty, all etc
| } | ||
|
|
||
| /** | ||
| * Inverse operation of [RequestOptions.toInputDescriptor] |
There was a problem hiding this comment.
just add a little more documentation, i.e. when this would be needed?
| @@ -121,6 +121,12 @@ data class RequestOptions( | |||
| /** | |||
| * Miscellaneous helper functions regarding [ConstraintField] | |||
| */ | |||
| private fun Collection<ConstraintField>.toRequestedAttributes(): List<String> { | |||
| val regex = "[a-zA-Z0-9_-]+".toRegex() | |||
| val rawAttributes = this.map { constraint -> constraint.path.last().split("[").last() } | |||
There was a problem hiding this comment.
This seems it should be handled by JSON Path? / cc @acrusage-iaik
There was a problem hiding this comment.
since we cannot use schema-matching according to v2.0.0 or later this needs to be reworked.
n0900
requested review from
acrusage-iaik
and removed request for
acrusage-iaik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds inverse operations to get back RequestOptions which were used to generate InputDescriptor.
This is useful if an incoming request needs to be manipulated.