set HttpAsyncClientSingleton.HTTPC_CLIENT = null on shutdown #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting HTTP_CLIENT to null on ConnectorCommon.shutdown()
lucnygr
changed the title
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using the NextcloudConnector, shutting it down with NextcloudConnector.shutdown() and using it afterwards again in the same JVM (for example when executing multiple integration-tests after each other) the HTTPC_CLIENT does not get initialized because its not null. the HTTPC_CLIENT-instance is in the STOPPED-state, so further executions with the client dont work.
PR: cleanup singleton-instance of HttpAsyncClientSingleton.HTTPC_CLIENT by setting the HTTP_CLIENT to null on ConnectorCommon.shutdown()