Integration of JSON response handling#62
Merged
a-schild merged 1 commit intoa-schild:masterfrom Sep 9, 2021
Merged
Conversation
Owner
|
I havent looked into details, but does the API user need to choose between XML and JSON or are we automatically using JSON for this API call? |
Author
|
the parsing method is chosen automatically using the type of response parser (https://github.com/kriszman/nextcloud-java-api/blob/0b1da4cf92a509950d406bfb1dd2a582c8c5d988/src/main/java/org/aarboard/nextcloud/api/utils/ConnectorCommon.java#L255) via "instanceof" (eg. https://github.com/kriszman/nextcloud-java-api/blob/0b1da4cf92a509950d406bfb1dd2a582c8c5d988/src/main/java/org/aarboard/nextcloud/api/utils/ConnectorCommon.java#L62), so I didn't touch the existing calls |
Owner
|
Thanks for the code, works as intended, will release a new version soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@a-schild added the possibility to choose between XML/JSON parsing in order to fix the XML issues we had in #58
I also enhanced the tests related to user provisioning accordingly, but i had some issues with some of the other tests (mainly uploading issues), though they are not related to the changes I did.