exposed fill_value to protein_to_pyg function #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierandidi
force-pushed
the
feat/control_fill_value
branch
from
3da6e06
to
2458b68
Compare
for more information, see https://pre-commit.ci
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 40.27% 45.05% +4.78%
==========================================
Files 48 113 +65
Lines 2811 7919 +5108
==========================================
+ Hits 1132 3568 +2436
- Misses 1679 4351 +2672 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes
Exposing the fill_value for atom37 representations to the protein_to_pyg function so that the user can choose this and it is transparent where the value comes from.
What testing did you do to verify the changes in this PR?
Pull Request Checklist
./CHANGELOG.mdfile (if applicable)./graphein/tests/*directories (if applicable)./notebooks/(if applicable)python -m py.test tests/and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,python -m py.test tests/protein/test_graphs.py)black .andisort .