-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FoldCompDataset calls graphein.protein.tensor.Protein with incorrect __init__ arguments #317
Comments
a-r-j
added a commit
that referenced
this issue
May 10, 2023
Hey @mawright thanks for pointing this out. I’d fixed this locally and forgotten to update this. Will merge as soon as tests pass. Apologies! |
a-r-j
added a commit
that referenced
this issue
May 11, 2023
* add PSW to nonstandard residues * improve insertion and non-standard residue handling * refactor chain selection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused verbosity arg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix chain selection in tests * fix chain selection in tutorial notebook * fix notebook chain selection * fix chain selection typehint * Update changelog * Add NLW to non-standard residues * add .ent support * add entry for construction from dataframe * add missing stage arg * improve obsolete mapping retrieving to include entries with no replacement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * add transforms to foldcomp datasets * fix jaxtyping syntax * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * fix double application of transforms * improve foldcomp data loading performance * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * linting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * add B factors to FC parsing output * bugfix to alpha & kappa angle embedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * handle selenocysteine in sidechain torsion angle computation * fix protein data object initialisation #317 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restore eq dunder * update changelog --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-r-j
added a commit
that referenced
this issue
May 19, 2023
) * add PSW to nonstandard residues * improve insertion and non-standard residue handling * refactor chain selection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused verbosity arg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix chain selection in tests * fix chain selection in tutorial notebook * fix notebook chain selection * fix chain selection typehint * Update changelog * Add NLW to non-standard residues * add .ent support * add entry for construction from dataframe * add missing stage arg * improve obsolete mapping retrieving to include entries with no replacement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * add transforms to foldcomp datasets * fix jaxtyping syntax * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * fix double application of transforms * improve foldcomp data loading performance * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * linting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * add B factors to FC parsing output * bugfix to alpha & kappa angle embedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * handle selenocysteine in sidechain torsion angle computation * fix protein data object initialisation #317 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restore eq dunder * update changelog * add x to foldcomp examples for correct batching --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-r-j
added a commit
that referenced
this issue
May 22, 2023
* add PSW to nonstandard residues * improve insertion and non-standard residue handling * refactor chain selection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused verbosity arg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix chain selection in tests * fix chain selection in tutorial notebook * fix notebook chain selection * fix chain selection typehint * Update changelog * Add NLW to non-standard residues * add .ent support * add entry for construction from dataframe * add missing stage arg * improve obsolete mapping retrieving to include entries with no replacement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * add transforms to foldcomp datasets * fix jaxtyping syntax * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * fix double application of transforms * improve foldcomp data loading performance * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * linting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * add B factors to FC parsing output * bugfix to alpha & kappa angle embedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * handle selenocysteine in sidechain torsion angle computation * fix protein data object initialisation #317 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restore eq dunder * update changelog * add x to foldcomp examples for correct batching * fix pnerf padding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
a-r-j
added a commit
that referenced
this issue
May 23, 2023
* add PSW to nonstandard residues * improve insertion and non-standard residue handling * refactor chain selection * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused verbosity arg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix chain selection in tests * fix chain selection in tutorial notebook * fix notebook chain selection * fix chain selection typehint * Update changelog * Add NLW to non-standard residues * add .ent support * add entry for construction from dataframe * add missing stage arg * improve obsolete mapping retrieving to include entries with no replacement * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * add transforms to foldcomp datasets * fix jaxtyping syntax * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * fix double application of transforms * improve foldcomp data loading performance * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * linting * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update changelog * add B factors to FC parsing output * bugfix to alpha & kappa angle embedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update changelog * handle selenocysteine in sidechain torsion angle computation * fix protein data object initialisation #317 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restore eq dunder * update changelog * add x to foldcomp examples for correct batching * fix pnerf padding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix padding in pnerf * bugfixes in angle computation * fix sc degree mask size * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update readme --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi y'all, love the library. It's been a huge help for me so far. I wanted to make use of the foldcomp integration but it isn't creating the Protein data objects correctly.
Describe the bug
This part here in
fc_to_pyg
:graphein/graphein/ml/datasets/foldcomp_dataset.py
Lines 297 to 305 in 47d9dde
tries to construct a
Protein
object, butProtein
's init method looks likegraphein/graphein/protein/tensor/data.py
Lines 134 to 136 in 47d9dde
so trying to get proteins out of
FoldCompDataset
always errors withTypeError: __init__() got an unexpected keyword argument 'coords'
To Reproduce
Steps to reproduce the behavior:
Expected behavior
FoldCompDataset
to iterate throughProtein
objectsDesktop (please complete the following information):
The text was updated successfully, but these errors were encountered: