Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loading bubble on chat screen #85

Merged

Conversation

EXTREMOPHILARUM
Copy link
Contributor

@EXTREMOPHILARUM EXTREMOPHILARUM commented Nov 4, 2024

Description

I've added a loading indicator with three dots to show that the model is processing, providing users with feedback that something is happening. I believe this will enhance the user experience by indicating activity. This is my first open-source PR in a while, so please let me know if any changes are needed. I’m also planning to contribute more improvements.

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
  • Unit tests and integration tests pass locally.

@EXTREMOPHILARUM EXTREMOPHILARUM force-pushed the feature/loading-chat-bubble branch from 1b6dc5b to ba0f56d Compare November 4, 2024 20:23
Copy link
Owner

@a-ghorbani a-ghorbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋. thanks for the PR. I love the loading indicator. Added a few comments.

src/components/LoadingBubble/LoadingBubble.tsx Outdated Show resolved Hide resolved
src/screens/ChatScreen/ChatScreen.tsx Outdated Show resolved Hide resolved
src/screens/ChatScreen/ChatScreen.tsx Outdated Show resolved Hide resolved
@EXTREMOPHILARUM
Copy link
Contributor Author

@a-ghorbani added the changes mentioned. Let me know if they are fine.

@a-ghorbani
Copy link
Owner

Thanks. It looks great!

@a-ghorbani a-ghorbani merged commit 8911e9f into a-ghorbani:main Nov 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants