Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improve edge-to-edge display implementation across Android versions #223

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

a-ghorbani
Copy link
Owner

@a-ghorbani a-ghorbani commented Feb 23, 2025

Description

Previous implementation of edge-to-edge display had compatibility issues with older Android versions (<=14) and required manual configuration of system bars, fails on even older ones (<=10).

This PR replaces manual configuration with official AndroidX Activity library's enableEdgeToEdge() function.

Fixes #219
Fixes #222

Platform Affected

  • iOS
  • Android

Checklist

  • Necessary comments have been made.
  • I have tested this change on:
    • iOS Simulator/Device
    • Android Emulator/Device
      • Verified working on:
        - Android 15 (API 35)
        - Android 14 (API 34)
        - Android 10 (API 29)
        - Android 9 (API 28)
  • Unit tests and integration tests pass locally.

@a-ghorbani a-ghorbani marked this pull request as ready for review February 23, 2025 08:58
@a-ghorbani a-ghorbani merged commit 8aade2e into main Feb 23, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The latest version is crashing. [Bug]: The latest version of flashback cannot be used
1 participant