Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type=address fields are not editable #628

Closed
gena01 opened this issue Sep 10, 2023 · 8 comments
Closed

Type=address fields are not editable #628

gena01 opened this issue Sep 10, 2023 · 8 comments
Labels
editor Editor pane, presets and fields
Milestone

Comments

@gena01
Copy link

gena01 commented Sep 10, 2023

It seems that some tags are missing when mapping letter boxes, things like support and post:* addresses would need much easier if they could be provided in the UI. I am sure there's possibly other tags missing as well.

@mnalis
Copy link
Contributor

mnalis commented Sep 10, 2023

I'm not sure if you mean amenity=post_box or amenity=letter_box when you say "letter boxes", but the former does include support=* when you click More fields.

But unless I'm wrong, Every Door uses id-tagging-schema for such presets, so you want to open issue there instead.

Or you could even do a PR, it looks simple enough:

https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/post_box.json

or

https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/letter_box.json

@gena01
Copy link
Author

gena01 commented Sep 10, 2023

I did mean amenity:letter_box.

Screenshot_20230910-143839
Screenshot_20230910-143835
Screenshot_20230910-143824

Updated with screenshots, what am I missing?

@gena01 gena01 changed the title amenity:letter_box mixing tags in the UI amenity=letter_box missing tags in the UI Sep 10, 2023
@mnalis
Copy link
Contributor

mnalis commented Sep 10, 2023

Thanks for clarification that this is about amenity=letter_box tag.

As I said above, the issue seems to be in another project called id-tagging-schema which Every Door uses, so you should report issue / suggest changes there (and then the next release of EveryDoor would pull those changes automatically)

@gena01
Copy link
Author

gena01 commented Sep 14, 2023

I am looking at their preset and it does have post tag. Somehow that's not recognized as post:* instead of the addr:* tag(s). This makes tagging things like house numbers on letter boxes a bit more challenging.

@mnalis
Copy link
Contributor

mnalis commented Sep 16, 2023

I've created PR for support tag at openstreetmap/id-tagging-schema#1005


As for post:*, you might be correct there @gena01. I'm not an expert there, but I think post field in https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/amenity/letter_box.json should be expanded to list of keys defined in https://github.com/openstreetmap/id-tagging-schema/blob/main/data/fields/post.json automatically.

That post field expansion however:

  • seems to work correctly for example in SCEE which uses id-tagging-schema (via osmfeatures) , showing all those post:* keys
  • It also seems to work in iD editor (although it seems to offer only 5 out of two dozen post:* keys? But that limiting is maybe due to iD UI-specific tweaks)
  • However, EveryDoor 3.1 does not seem to expand that post field at all in amenity=letter_box, but it is lost completely. It is unfortunately beyond me why (could be me missing something, but perhaps it might also be EveryDoor bug?)

@Zverik
Copy link
Owner

Zverik commented Sep 25, 2023

Every Door currently filters out fields with the address type, hence no post:*=*. Given it handles addresses differently, it may be tricky to implement. I'll let this hang around.

@Zverik Zverik changed the title amenity=letter_box missing tags in the UI Type=address fields are not editable Sep 30, 2023
@Zverik Zverik added the editor Editor pane, presets and fields label Sep 30, 2023
@Zverik Zverik added this to the 4.0 milestone Sep 30, 2023
@Zverik
Copy link
Owner

Zverik commented Sep 30, 2023

Done in 4.0.

@Zverik Zverik closed this as completed Sep 30, 2023
@mnalis
Copy link
Contributor

mnalis commented Dec 15, 2023

Just an note that support & colour tags have been added to amenity=letter_box in openstreetmap/id-tagging-schema#1005 (comment)

So hopefully next Everydoor build should be able to specify those, if I understand correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Editor pane, presets and fields
Projects
Status: Done
Development

No branches or pull requests

3 participants