Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes for item assignment in vec4 and mvec4. #55

Merged
merged 1 commit into from
Jan 23, 2020

Conversation

aforren1
Copy link
Contributor

For example, on the master branch:

import glm

x = glm.vec4()
x[3] = 1
print(x)
# vec4(            0,            0,            1,            0 )

y = glm.mat4(0)
y2 = y[0]
y2[3] = 1
print(y2)
# mvec4(            0,            0,            1,            0 )

z was used for the 3rd index in both cases, rather than w.
@Zuzu-Typ
Copy link
Owner

Thank you very much!

I've made so many of these little, yet fatal mistakes.. I would never have spotted them on my own.

@Zuzu-Typ Zuzu-Typ merged commit bc4db4d into Zuzu-Typ:master Jan 23, 2020
@aforren1
Copy link
Contributor Author

No problem, thanks for all the work you've put into this package!

@aforren1 aforren1 deleted the bf branch January 24, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants