[engine][bugfix]: Fixed bug where Horusec couldn't properly differentiate between .git/ and .github/ path #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermepaulozup
requested review from
lucasbrunozup,
matheusalcantarazup,
nathanmartinszup and
wiliansilvazup
as code owners
wiliansilvazup
approved these changes
Jun 8, 2022
Signed-off-by: guilhermepaulozup <guilherme.paulo@zup.com.br>
guilhermepaulozup
force-pushed
the
feature/ghaction
branch
from
5644adb to
75930e0
Compare
ne0z
pushed a commit
to ne0z/horusec-engine
that referenced
this pull request
Jun 23, 2022
Signed-off-by: guilhermepaulozup <guilherme.paulo@zup.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: guilhermepaulozup guilherme.paulo@zup.com.br
- What I did
Added a call to os.PathSeparator to isFileFromGitFolder to form a .git/ path.
This way the engine can properly differentiate between the .git/ directory and .github/ directory (used in Github Actions) files.
- How to verify it
Running
horusec start --log-level="debug"should properly read the files in .github/workflows/ folder.- Description for the changelog
Changed isFileFromGitFolder to include on the return:
".git"+string(os.PathSeparator)