Skip to content

Conversation

@fosskers
Copy link
Contributor

Removing UIOP as a main dependency reduces final binary sizes but also improves compatibility in certain scenarios (WASM).

This PR also moves the .asd files to match convention, but I'm happy to undo that if you prefer them where they were.

@fosskers
Copy link
Contributor Author

fosskers commented Sep 3, 2025

Hi, any thoughts?

(stringify-to stream)
nil)))))

;; NOTE: Borrowed from UIOP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check uiop's licence to see if it was ok to grab code from it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be MIT, which I interpret to mean "do whatever you want" (see https://opensource.org/license/mit).

@fstamour
Copy link
Contributor

fstamour commented Sep 6, 2025

I never remember the exact condition (not cl:condition 😅), but doesn't asdf complain (signals a warning) when there are multiple system files in the same directory?

@fosskers
Copy link
Contributor Author

fosskers commented Sep 6, 2025

As in, multiple .asd files? Seems to be okay with it, as far as I can tell.

@Zulu-Inuoe
Copy link
Owner

No problems from me. The tests are failing but I'm guessing that's due to some incompatible update to SBCL - I'll need to update the version used for tests

@Zulu-Inuoe
Copy link
Owner

I never remember the exact condition (not cl:condition 😅), but doesn't asdf complain (signals a warning) when there are multiple system files in the same directory?

FYI you're probably thinking of two system definitions in the same file - ASDF would want them named in a specific way, foo and foo/test, it would be mad with foo and foo-test

@Zulu-Inuoe Zulu-Inuoe merged commit 85a22b9 into Zulu-Inuoe:develop Sep 8, 2025
1 check failed
@fosskers fosskers deleted the colin/no-uiop branch September 8, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants