Skip to content

Revert autodownload change #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Revert autodownload change #135

merged 1 commit into from
Sep 25, 2022

Conversation

Tha14
Copy link

@Tha14 Tha14 commented Sep 25, 2022

No description provided.

@Tha14 Tha14 requested a review from zoff99 September 25, 2022 12:26
@zoff99
Copy link

zoff99 commented Sep 25, 2022

hm yeah. the issue is that when you disable autodownload people not familiar enough will never get any files.
do you have a solution for this standard case:

a person sends a photo and a message -> antidote will receive a push notification, and will stay awake for 3 minutes, a download will show -> user is somewhere not reacting to the push notification -> after 3 minutes the download will fail.
the sending party has no idea why their file sends always fail. receiver has no idea why download always fail.
both parties are frustrated and uninstall because it sucks.

@zoff99
Copy link

zoff99 commented Sep 25, 2022

lets revert it for now, so that we can make a release. but keep discussing how to fix the user facing issue ...

@Tha14
Copy link
Author

Tha14 commented Sep 25, 2022

hm yeah. the issue is that when you disable autodownload people not familiar enough will never get any files. do you have a solution for this standard case:

a person sends a photo and a message -> antidote will receive a push notification, and will stay awake for 3 minutes, a download will show -> user is somewhere not reacting to the push notification -> after 3 minutes the download will fail. the sending party has no idea why their file sends always fail. receiver has no idea why download always fail. both parties are frustrated and uninstall because it sucks.

Don't care, I'm not changing default behavior and especially for an option that is first in the list of settings. Also, not putting people at risk for it.

@zoff99
Copy link

zoff99 commented Sep 25, 2022

autodownload = false wont save you from receiving something that you may not want, since you do not see the content until you have actually downloaded it.

@zoff99 zoff99 merged commit f674941 into Zoxcore:develop Sep 25, 2022
@Tha14 Tha14 deleted the autodownload_only_wifi_def branch September 25, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants