Skip to content

Conversation

@richb-hanover
Copy link
Contributor

Update screen shots to 0.3 version;
Update text to match;
Create UNDERSTANDING.md page;
Factor command line info from README into COMMANDLINE.md file;
Add batch_add_border.sh script for simple screen-shot processing;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just do a local test to avoid the odd sensoring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happen to be at my Mom's house today, where the network is fast but has high latency. I think these charts are better - showing typical results, not the "best possible" when using a good router.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the client screenshot doesn't have to match the result. You could also save and add the result to the data folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the files are good now.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't changed them?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to do these changes in the code too.

@richb-hanover
Copy link
Contributor Author

[I'm going off-grid for about 8 or 9 hours. These are good comments: keep sending them. I will address them when I return. Thanks]

@richb-hanover
Copy link
Contributor Author

Any further changes necessary? Thanks again

It also incorporates a continuous latency tester for
monitoring background responsiveness.

Crusader uses TCP and UDP ports 35481 (only) for its tests.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably keep this and add something like:
Traffic generation uses TCP while UDP is used for latency and packet loss measurements.

@Zoxc
Copy link
Owner

Zoxc commented Oct 3, 2024

I'm not really sure what changes to the screen shots you would like to see.

I just wanted fresh new screenshots so they exactly match the actual application.

@richb-hanover
Copy link
Contributor Author

I am feeling stuck:

  • I believe it's important that the screen shots show real-world tests with less than perfect performance
  • I am not willing to display my personal test server's address in the screen shots.
  • It's enough work to prepare screen shots that I'm not willing to revise continually.

What do you suggest? I would be completely content for you to commit this PR, then make your own editorial changes/substitute screen shots. Would that work? Thank you.

Create a LOCAL_TESTS.md file;
Passes various markdown tests
@richb-hanover
Copy link
Contributor Author

@Zoxc I re-organized the repo to collect all the separate instruction files into a docs directory. I also created a "Running Local Tests" document, because I think this is an important use of Crusader.

What needs to happen to move this PR along? Thank you

@richb-hanover
Copy link
Contributor Author

@Zoxc I continue to use Crusader, and recommend it in my blog and on various forums (example: Reddit)

In particular, I would like to link to docs/LOCAL_TESTS.md for testing Wifi. But it hasn't yet been merged into the main repo.

What needs to be done to make this PR (#79) suitable for merging? Thanks.

@richb-hanover
Copy link
Contributor Author

@Zoxc It has been six months since 0.3.2 was released. Do you think this PR could be merged? Thanks

@richb-hanover
Copy link
Contributor Author

@Zoxc Thank you for the careful reading! I will make these changes in the next couple days and let you know.

@richb-hanover
Copy link
Contributor Author

Good suggestions. I note that the build has failed now. Is that something you need to correct? Thanks.

@Zoxc Zoxc merged commit 5d1e6e7 into Zoxc:master Apr 29, 2025
1 of 2 checks passed
@Zoxc
Copy link
Owner

Zoxc commented Apr 29, 2025

Is that something you need to correct?

Yeah, it looks like a GitHub image update broke it.

@richb-hanover richb-hanover deleted the Tweak-0.3-docs branch April 29, 2025 12:33
@richb-hanover
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants