activate php82 sniffs #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are in parts of the code i didn't touch + MSI > 95%. I'd argue that it's very approvable ^^ |
breadbakerman
approved these changes
Feb 26, 2024
eric-hess
approved these changes
Feb 26, 2024
farzamtm
approved these changes
Feb 26, 2024
matthias-ruester
approved these changes
Feb 26, 2024
Co-authored-by: Matthias Rüster <129733442+matthias-ruester@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes will only apply to PHP 8 code only. The rules will not touch PHP 7.4 compatible code. If your composer.json states in
require->phpthat your code ist 7.4 compatible the rules will not apply.