Use different PHP version information for PHPCS and PHPStan #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rdss-sknott
commented
Feb 13, 2024
rdss-sknott
commented
- Split version decorators in MinimalVersionDecorator and VersionDecorator
rdss-sknott
force-pushed
the
minimal-php-version
branch
from
b6b1063 to
f94e568
Compare
rdss-sknott
changed the title
* Split version decorators in MinimalVersionDecorator and VersionDecorator * Updated min versions of some dependencies
rdss-sknott
force-pushed
the
minimal-php-version
branch
from
f94e568 to
9a0db79
Compare
jhofm
approved these changes
Feb 13, 2024
rdss-pwacht
approved these changes
Feb 13, 2024
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\Multiprocess\MultiprocessTerminalCommand; | ||
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\Multiprocess\MultiprocessTrait; | ||
| // phpcs:ignore -- I did not find a way to either break this line or to make it shorter. | ||
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\PhpVersion\MinimalVersionDependantTerminalCommand; |
There was a problem hiding this comment.
this would be possible, but does not quite make it more readable I think 😅
use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\PhpVersion\{
MinimalVersionDependantTerminalCommand,
MinimalVersionDependentTrait,
PhpVersionConverter
};There was a problem hiding this comment.
yeah. thought about that but came to the same conclusion as you did. :/
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\PhpVersion\ComposerInterpreter; | ||
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\PhpVersion\ConstraintToVersionConverter; | ||
| use Zooroyal\CodingStandard\CommandLine\StaticCodeAnalysis\Generic\TerminalCommand\PhpVersion\MinimalVersionDecorator; | ||
| // phpcs:ignore -- I did not find a way to either break this line or to make it shorter. |
There was a problem hiding this comment.
like above: could be shortened with use MyNamespace\{ClassA, ClassB}
rdss-hmorsi
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.