Remove rules not compatible with new PHP 8.2 syntax #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "PSR1.Files.SideEffects.FoundWithSymbols" wrongly identifies read-only keyword as side effect * "Squiz.Classes.ClassDeclaration.SpaceBeforeKeyword" wrongly expects class keyword to be first in line * No need to be backwards compatible because coding-standard adapts to PHP version on it's own
rdss-sknott
force-pushed
the
php-82-sniff-incompatible
branch
from
b0d957a to
b6ac905
Compare
rdss-pwacht
approved these changes
Oct 25, 2023
jhofm
approved these changes
Oct 25, 2023
farzamtm
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyword as side effect
class keyword to be first in line
PHP version on it's own