Improve delete event #696
Merged
Improve delete event #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
load the relevant event data if passed an eid. Use the StartTime to get to the event files instead of globbing the entire events path under the monitor.
|
Don't merge yet, it has a problem. |
|
should be ok now |
|
Looks good to me. Obviously, if FAST_DELETE is on, we are letting the zmaudit daemon do the deleting.... but do we know if zmaudit has similar code that could also be improved in the same manner? |
|
correct, I havn't looked at zmaudit yet. I've just been auditing the web code trying to fix sluggishness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that deleting an event globbed the entire event structure under a monitor. That made for some pretty bad performance on my systems with a lot of events.
This converts the deleteEvent function to handle an event hash or an eid and use the StartTime value to figure out which day the event happened and so we only glob that day which drastically reduces filesystem hits.