Skip to content

Conversation

@IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Aug 26, 2025

The code implements support for disabling ALL players, including "ZMS MJPEG", but the UI does not currently use disabling all players. Because at the moment I am not sure that it is necessary to disable all players.
To implement enabling/disabling "ZMS MJPEG" you need to uncomment some lines of code and add a field to the DB ALTER TABLE MonitorsADD COLUMNZMSEnabledBOOLEAN NOT NULL default true AFTERDecoding``

It looks like this: #4393 (comment)

Also added the ability for <input> to use ".disabled", because if you use the "disabled" attribute for <input>, then the value of <input> will not be used in the form. And now, if you add the "disabled" class, then the value of <input> will be used in the form, but you cannot change its value manually in the UI.

If this PR is approved, then in the future you can remove the checkboxes for controlling player enablement from the UI and visually combine the options into the Go2RTC, RTSP2Web & Janus groups

I'm not sure about the feasibility of this PR, but I had some ideas and decided to publish them. Probably, choosing to enable/disable players in one place (in "multi select") is better than many checkboxes.

@IgorA100 IgorA100 marked this pull request as ready for review August 26, 2025 21:42
@IgorA100 IgorA100 marked this pull request as draft September 2, 2025 15:40
@IgorA100 IgorA100 marked this pull request as ready for review September 2, 2025 15:50
@IgorA100
Copy link
Contributor Author

IgorA100 commented Sep 9, 2025

This PR is not needed?

@IgorA100
Copy link
Contributor Author

@connortechnology
Haven't you watched this PR yet?
I'm interested in your opinion.

@connortechnology
Copy link
Member

It is not clear to me why we would want to disable ZMS playback. The .disabled stuff makes sense.

@IgorA100
Copy link
Contributor Author

IgorA100 commented Dec 10, 2025

disable ZMS playback

This PR does NOT disable ZMS playback!
The code to disable ZMS playback does exist, but it's locked!

At first, I thought about disabling all players, including ZMS, but I later realized that wasn't necessary and locked the code.

This PR changes the player selection style. I plan to remove the checkboxes (which are quite confusing if there are more than two players) and switch to multi-select. I think it will be more convenient and look better.

@IgorA100
Copy link
Contributor Author

IgorA100 commented Feb 5, 2026

@connortechnology
Should I test this PR on the current version of ZM?
Or should I close this PR?

It's been almost six months, and I can't figure out what to do with this PR...

@connortechnology
Copy link
Member

It is still not clear to me why we need it. Why would we want to disable zms?

@IgorA100
Copy link
Contributor Author

IgorA100 commented Feb 5, 2026

It is still not clear to me why we need it.

This PR will allow users to select available players using multi-select, rather than the current checkboxes. The checkboxes themselves will remain visible for now, but they are disabled for editing. In the future, the checkboxes could be completely removed by revising the page layout.

Why would we want to disable zms?

We are NOT disabling ZMS in this PR!!!

333

@IgorA100
Copy link
Contributor Author

IgorA100 commented Feb 6, 2026

@connortechnology
The main idea is to get rid of the checkboxes, of which there are already many on the page, and make the selection of available players via multi-select. ZMS is NOT disabled!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants