use proper DBI parameter passing to improve security#264
Merged
kylejohnson merged 1 commit intomasterfrom Dec 13, 2013
Merged
Conversation
remark out call to zmupdate.pl -f
Member
There was a problem hiding this comment.
zmupdate -f simply reads info from the dB and turns around and writes it right back to the dB. It looks like user Stan added this back in 2011, but I don't know what his intent was. This same command was also part of the stock zm init script, but after discussing it with mastertheknife I commented it out (the one in the init file).
TLDR: This might be the cause of the Conig table corruption issue.
Member
Author
There was a problem hiding this comment.
The thing is, if you are going to modify the Config Table, you have to exclusively lock it so that nothing reads in the meantime.
kylejohnson
added a commit
that referenced
this pull request
Dec 13, 2013
Use proper DBI parameter passing in zmpkg.pl to improve security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remark out call to zmupdate.pl -f