Skip to content

Apply INSERTs in Event::AddFrames in batches to fix issue #222#223

Merged
mastertheknife merged 1 commit intoZoneMinder:masterfrom
fastolfe:batch-frame-inserts
Oct 29, 2013
Merged

Apply INSERTs in Event::AddFrames in batches to fix issue #222#223
mastertheknife merged 1 commit intoZoneMinder:masterfrom
fastolfe:batch-frame-inserts

Conversation

@fastolfe
Copy link
Contributor

I've tested this on my own installation successfully.

@mastertheknife
Copy link
Contributor

This looks like a good solution to the problem for now, until we re-write the event class in the future.
Lets wait few days to see if anyone objects to merging this

@knight-of-ni
Copy link
Member

Yes, this is a good idea. Although, out of curiosity, I am interested in knowing the need to have such a large image buffer.

Tying this to issue #222

@fastolfe
Copy link
Contributor Author

With respect to "why", I'm troubleshooting a large lag time between when motion occurs in a scene and when recording begins. Several seconds of significant motion seem to pass before frames begin making it to disk, so I'm bumping up the image buffer to ensure I capture the start of the motion while I work on why it's not working well.

(Incidentally, I'm new to the github workflow; is there a way I could have created the pull request and associated it with this issue in one go?)

@knight-of-ni
Copy link
Member

@fastolfe
Make sure the Maximum FPS and Alarm Maximum FPS fields are left empty for IP cameras. That can cause the symptoms you describe.

When I create a pull request, I just mention the issue number in the description to tie the two together. Not sure if there is a better way.

@mastertheknife
Copy link
Contributor

@fastolfe
The way you did the pull request is perfect, its clean and has its own branch.
Using # before the issue number will automatically reference the pull request to the issue.
The code looks good, and we waited few days, its all good.

mastertheknife added a commit that referenced this pull request Oct 29, 2013
Apply INSERTs in Event::AddFrames in batches to fix issue #222
@mastertheknife mastertheknife merged commit 234e742 into ZoneMinder:master Oct 29, 2013
@fastolfe fastolfe deleted the batch-frame-inserts branch October 30, 2013 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants