Merged
Conversation
1) Cleaner code 2) Fixed the path displayed in the addr2line line 3) Improved dependency checking for backtrace 4) Few more improvements
…d by siginfo and ucontext) 2) Removed the checks for sigcontext, strsignal and siginfo.h 3) Added debugging code to the die handler 4) Using SA_RESTART in the hup and reload handlers to prevent certain functions returning EINTR 5) Added SIGINT and SIGQUIT to the term handler
… have proper dependency checking
Contributor
Author
|
Anyone objects to merging this? |
Member
|
not here. |
mastertheknife
added a commit
that referenced
this pull request
Oct 7, 2013
Signal improvements and fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were few issues in zm_signal:
addr2line -e /home/kfir/zmwork/ZoneMinder/src/zmc() 0x7ffff7172500 0x42d5c8 0x7ffff4627cdd 0x42cc79
Instead of this:
addr2line -e /home/kfir/zmwork/ZoneMinder/src/zmc 0x7ffff7172500 0x42d5c8 0x7ffff4627cdd 0x42cc79
I have made the code more readable, and also used indent -linux to clear the mix of few lines using spaces, while others are using tabs. It converted the whole file to use tabs and did appearance changes to the file