RtspServer include has long list of all operating systems in ifdef

[gdt]

Describe Your Environment

• RtspServer master

Describe the bug

In src/net/Socket.h there are conditionals that look like

#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)

and for the most part this is about "windows" vs "mostly-POSIX operating system".

We have to patch these to add || defined(__NetBSD__). It would be less changes to maintain/merge if we didn't, and it would also mean that the next person on FooBSD or illumos won't need to patch either.

Discussion

I'm not sure if this can just be "if windows, then windows-version, else", but if so that would be great.

[gdt]

(Filed here because RtspServer does not have issues enabled.)

[gdt]

If we can't flip to "if windows, do windows way, else do unix way", because it won't work, or it is rejected, then I can prepare a PR to add NetBSD to all such conditionals.

$ egrep -R OpenBSD .
./src/xop/rtsp.h:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/xop/rtsp.h:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Socket.h:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Socket.h:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/NetInterface.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/EventLoop.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/TaskScheduler.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/TaskScheduler.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Timestamp.cpp:#elif  defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/BufferWriter.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Pipe.cpp:#elif defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Pipe.cpp:#elif defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Pipe.cpp:#elif defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/Pipe.cpp:#elif defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SelectTaskScheduler.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SelectTaskScheduler.h:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SocketUtil.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SocketUtil.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SocketUtil.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/SocketUtil.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
./src/net/TcpSocket.cpp:#if defined(__linux) || defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)

[connortechnology]

I'm fine with it... perhaps we should try to upstream the change, but not much gets merged over there.

[gdt]

Do you want "windows vs not windows", or "add NetBSD to all"? Happy to do it your way, just would like to do it only once :-)

(As for upstream, it seems like zm has become the upstream, and would suggest asking the real upstream to take changes back be kept async from doing what we need to do.)

[connortechnology]

I'm fine with if windows/not windows

[gdt]

ZoneMinder/RtspServer#12