Make SDK configurable, defaulting to speculos default values #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamtamHero
changed the title
TamtamHero
changed the title
|
What are speculos default values? |
|
I am worried that this change may not be backwards compatible and may introduce compatibility issues with existing apps. |
|
https://github.com/LedgerHQ/speculos/blob/master/speculos/main.py#L256-L257 Zemu currently use default value for Nano X but not Nano S. Current default value for Nano S would be 2.1 instead of 2.0, which shouldn't break anything as syscalls addresses are not changing from a version to another anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.