Add Vara Network #172
Closed
Add Vara Network #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys! I apologize for the direct mention, but we really need this PR reviewed. Could you please take a look at it whenever you're available? Thank you! |
|
@chcmedeiros Requesting review, please. |
|
@nikitayutanov are you using the generic app ? |
|
@chcmedeiros Yes, we are. |
|
@nikitayutanov Then this it is not required anymore, as the generic app does not depend on that list. Before, PolkadotJS was depending on that list to enable generic app access on the wallet, but I think they are not anymore. |
|
@chcmedeiros Alright, thanks. I should've done more investigation probably, I will make sure and will close the PR if that's the case. |
|
No worries! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 zboto Link