Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing cases in constant resolution #1050

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Implement missing cases in constant resolution #1050

merged 3 commits into from
Nov 23, 2021

Conversation

Schaeff
Copy link
Member

@Schaeff Schaeff commented Nov 15, 2021

closes #1038 and #1047

@Schaeff Schaeff requested a review from dark64 November 16, 2021 09:09
dark64
dark64 reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@dark64 dark64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should we add a test that covers this case? Just to be sure, happy to merge without if you think it's unnecessary.

@Schaeff
Copy link
Member Author

Schaeff commented Nov 17, 2021

Half of these tests fail on develop, which is the expected result, as file names matter.

@Schaeff Schaeff merged commit 2a63d8d into develop Nov 23, 2021
@Schaeff Schaeff deleted the fix-constant-reduction branch November 23, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dark64 dark64 dark64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation failed while importing constants
2 participants
@Schaeff @dark64