Fail at compile time on unsatisfied equality of complex values #1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1031 but since this happens in zir we can't point at which assertion failed. I assume this will be easier once #1012 is in as we would still have the source location and optional message. Note that now in the
typed_absy
propagation, we show which expression ended up being false, but this is not always the original expression, it is the expression after the previous pass (which can expose some compiler internal variables unfortunately):Will fail with
All in all, #1012 will be nice as it has a reference to the original source, not to the previous pass, for both typed_absy and zir propagation.