fix: ensure SkillRequirement checks doesn't try to stack boosts #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajlada
force-pushed
the
fix/boosts-taking-boosted-levels-into-consideration
branch
from
9d4a895 to
203604a
Compare
Zoinkwiz
approved these changes
Jan 12, 2025
pajlada
deleted the
fix/boosts-taking-boosted-levels-into-consideration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://discord.com/channels/772056816242130964/772059156710031390/1326472562494013452
This change was split up into 2 commits
If you run the tests on the first commit, you'll see the test on line 51 fail, and that's the one @Spaenny described in Discord.
With the second commit applied, which includes a bunch of refactoring & the actual fix, you'll see it and all other tests pass.