Open
Conversation
Refactored for better structure, readability, and performance: - Split large methods and grouped related ones - Used modern PHP features (arrow functions, return types, fn()) - Replaced app()->basePath() with config_path() - Improved config publishing with tags - Extended provides() to include 'entrust' - Improved comments and naming - Removed redundant code - Fully backward compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Improvements
Better Code Structure
Modern PHP Features
fn()for simple callbacksReadability Improvements
Performance and Optimization
app()->basePath()withconfig_path()for cleaner config accesstagsupport for publishing configurationService Provider Enhancements
provides()method to include the'entrust'serviceBackward Compatibility