Merge pull request kayak#549 from magiskboy/subquery-in-function

Surround subquery in the args aggregate function

pypika/terms.py

@@ -1259,7 +1259,12 @@ def get_function_sql(self, **kwargs: Any) -> str:
 
         return "{name}({args}{special})".format(
             name=self.name,
-            args=",".join(self.get_arg_sql(arg, **kwargs) for arg in self.args),
+            args=",".join(
+                p.get_sql(with_alias=False, subquery=True, **kwargs)
+                if hasattr(p, "get_sql")
+                else self.get_arg_sql(p, **kwargs)
+                for p in self.args
+            ),
             special=(" " + special_params_sql) if special_params_sql else "",
         )
 

pypika/tests/test_functions.py

@@ -413,6 +413,11 @@ def test__approx_percentile(self):
             str(q),
         )
 
+    def test__subquery_in_params_functions(self):
+        subquery = Query.from_('table').select('id')
+        func = fn.Function('func', 'id', subquery)
+        self.assertEqual("func('id',(SELECT id FROM table))", func.get_sql())
+
 
 class ConditionTests(unittest.TestCase):
     def test__case__raw(self):