Skip to content

added manage for hitl #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added manage for hitl #1259

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6987b57
added manage for hitl
vishnuszipstack Apr 21, 2025
3ef9294
Merge branch 'main' into feat/hitl-auto-approve
Deepak-Kesavan Apr 22, 2025
bfe5ce1
Merge branch 'main' into feat/hitl-auto-approve
vishnuszipstack Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/routes/useMainAppRoutes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ let PRODUCT_NAMES = {};
let ManualReviewPage;
let SimpleManualReviewPage;
let ReviewLayout;
let Manage;
let UnstractUsagePage;
let UnstractSubscriptionPage;
let UnstractSubscriptionCheck;
Expand Down Expand Up @@ -79,6 +80,7 @@ try {
require("../plugins/manual-review/review-layout/ReviewLayout.jsx").ReviewLayout;
SimpleManualReviewPage =
require("../plugins/manual-review/page/simple/SimpleManualReviewPage.jsx").SimpleManualReviewPage;
Manage = require("../plugins/manual-review/page/manage/Manage.jsx").Manage;
} catch (err) {
// Do nothing, Not-found Page will be triggered.
}
Expand Down Expand Up @@ -200,6 +202,7 @@ function useMainAppRoutes() {
path="review/approve"
element={<ManualReviewPage type="approve" />}
/>
<Route path="review/manage" element={<Manage />} />
</Route>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishnuszipstack It looks like SimpleManualReviewPage and Manage are not being checked for availability in the condition: ReviewLayout && ManualReviewPage && (<Route> ... </Route>). Can we add checks for these components as well to ensure they are defined before rendering the route?

</>
Expand Down