Skip to content

feat: Make request header part of class #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: Make request header part of class #5

merged 2 commits into from
Jul 10, 2024

Conversation

chandrasekharan-zipstack
Copy link
Collaborator

What

  • Refactored to set the request headers as an attribute of the class
  • Bumped version to 0.2.1

Why

  • Helps ease testing locally - would allow to easily modify code in 1 place to add headers like Subscription-Id

@chandrasekharan-zipstack
Copy link
Collaborator Author

The test failures are expected, its related to the last line missing from LLM Whisperer output - it'll be fixed once LLM whisperer changes are released to prod

@jaseemjaskp jaseemjaskp merged commit bb384fd into main Jul 10, 2024
1 check failed
@jaseemjaskp jaseemjaskp deleted the feat/make-request-header-part-of-class branch July 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaseemjaskp jaseemjaskp jaseemjaskp approved these changes

@arun-venkataswamy arun-venkataswamy Awaiting requested review from arun-venkataswamy

@johnyrahul johnyrahul Awaiting requested review from johnyrahul

Assignees

@chandrasekharan-zipstack chandrasekharan-zipstack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chandrasekharan-zipstack @jaseemjaskp