Skip to content

feat: Encoding added for response #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

chandrasekharan-zipstack
Copy link
Collaborator

@chandrasekharan-zipstack chandrasekharan-zipstack commented Oct 29, 2024

What

  • Encoding of "utf-8" added by default for response in v1 and v2 clients
  • Test cases added to check for utf-8 support
  • Version bumped to 0.22.0

NOTE: Encoding is not added yet to the initial request due to the requirement of magic and subsequent installation of libmagic for clients to deduce the Content-Type header that needs to be sent. This can be supported in the client and server once there's a request for it

Copy link
Contributor

@jaseemjaskp jaseemjaskp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandrasekharan-zipstack chandrasekharan-zipstack deleted the feat/encoding-added-for-response branch October 30, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants